Skip to content

Update tests after OpenCLKernel attribute rename#3216

Merged
MrSidims merged 1 commit intoKhronosGroup:mainfrom
svenvh:kernel-attr-tests
Jun 12, 2025
Merged

Update tests after OpenCLKernel attribute rename#3216
MrSidims merged 1 commit intoKhronosGroup:mainfrom
svenvh:kernel-attr-tests

Conversation

@svenvh
Copy link
Member

@svenvh svenvh commented Jun 6, 2025

Update after llvm-project commit 3b9ebe92011b ("[clang] Simplify device kernel attributes (#137882)", 2025-06-05).

Update after llvm-project commit 3b9ebe92011b ("[clang] Simplify
device kernel attributes  (#137882)", 2025-06-05).
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svenvh
Copy link
Member Author

svenvh commented Jun 12, 2025

Probably also make sense to update https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/main/test/transcoding/annotation_dbg_info_drop.ll while we are here

Nice catch; I wondered why that test didn't fail, turns out it was XFAILed:

; need to rewrite the entire test since with opaque pointers a lot of bitcasts
; are being eliminated, and those bitcasts were carrying debug information
; XFAIL: *

Perhaps it's time to remove this test, given that debug info intrinsics are being retired; or do you think the original problem covered by this test may still occur with the new debug info record infrastructure?

@MrSidims
Copy link
Contributor

@svenvh oh, I haven't noticed, that it's XFAILed. Let me cover this later.

@MrSidims MrSidims merged commit 221039c into KhronosGroup:main Jun 12, 2025
6 of 8 checks passed
@svenvh svenvh deleted the kernel-attr-tests branch June 12, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants